KSP-SpaceDock / SpaceDock

Current Codebase (Python /Flask)
https://spacedock.info
Other
73 stars 33 forks source link

[Feature] Show CKAN badge for mods not added directly through Spacedock #442

Open drewcassidy opened 2 years ago

drewcassidy commented 2 years ago

Description (What went wrong?):

Right now the CKAN badge only shows up on mods that were added by clicking the checkbox in spacedock. This could lead to mods showing the badge if the mod couldn't be indexed for whatever reason. It also leads to mods added through other means not showing the badge which could confuse users into thinking its not available from CKAN

Solutions:

HebaruSan commented 2 years ago

This could lead to mods showing the badge if the mod couldn't be indexed for whatever reason.

This part was already addressed, admins can uncheck the checkbox as of #337.

mods added through other means not showing the badge

This can be handled by an admin checking the checkbox as needed. An automated pull request would be created, but it can simply be ignored and closed in one click.

  • Just a checkbox, and trust the mod maker

I'm not sure what this means. Isn't that the current state? But it's listed under "Solutions"?