Closed Rexicon226 closed 1 year ago
Hi @Rexicon226, did you intend to submit this, or was it a mis-click? I ask because I know GitHub's web UI can be tricky to learn, and the description of the change is missing, which we need in order to review it. If you didn't intend to suggest this for inclusion in the SpaceDock core code, we can just close it.
A pull request should always include:
At this point with h3
a very commonly used element across SpaceDock and margin-top
a pretty impactful stylesheet property, the sane thing to with a pull request making this change for no stated reason would be to just close it. If you can flesh this out within a couple of days, we won't have to go that route. Cheers!
Sorry about the lack of detail, I was looking over the database, and I noticed that this is a completely unused line of code. I'm not too bad at front-end design :P. If you look closely you can see that margin-top
is defined twice, and is overridden, making the top line completely useless. I think that practicing clean code should be a priority. @HebaruSan
This is a completely unused line of code;
margin-top
is defined twice, and is overridden, making the top line completely useless.🤔