KSP-SpaceDock / SpaceDock

Current Codebase (Python /Flask)
https://spacedock.info
Other
72 stars 33 forks source link

Make sure JNO versions aren't empty #497

Closed HebaruSan closed 1 year ago

HebaruSan commented 1 year ago

Problem

A game version with an empty version string has been added, then deleted, then added again a couple of times:

image

Cause

We don't know the exact cause of this since there are 2 or 3 different automated sources for this data currently:

However, we can construct a plausible narrative of how it happens: If the API sometimes glitches out and returns an empty string, the built-in support from #480 would add that empty string to the db because it doesn't check it.

However², the alpha and beta servers have both been using this code the same way as production, and neither has had this issue so far, so this explanation is not very likely.

Changes

If this is the cause, this will fix the problem.