KSP-SpaceDock / SpaceDock

Current Codebase (Python /Flask)
https://spacedock.info
Other
73 stars 33 forks source link

Modpacks that have / in their names become inaccessible #500

Open tempodat opened 1 year ago

tempodat commented 1 year ago

Description (What went wrong?): I created a Modpack for KSP2 called "New/Updated Parts Mods". When I tried saving changes after editing it it showed me the 404 screen that shows this modpack doesn't exist. I can't edit or even rename or delete it now, when I try I get a 404.

Reproduction Steps (What did you do?): Create a modpack that has a / character in its name. Try to edit or view it afterwards. There might be more characters that break it.

Expected Behavior (What do you think should have happened instead?): The normal creation of a modpack, along with it being possible to access it.

Environment (OS/Browser/Plugins/etc): Windows 10, Firefox.

Extra Information (Screenshots/Error Messages/Javascript Console Output): I think this fails because the / is messing with the URL, so substituting / for %2F or an underscore or something when constructing URLs should fix this. Also there might be other characters that cause this, not just "/".

My inaccessible modpack is linked here, for reference. https://spacedock.info/pack/489/New/Updated%20Parts%20Mods

HebaruSan commented 1 year ago

Hi @tempodat, thanks for the report. The name isn't used for anything, so as a workaround you can just change it to something else in the URL. This works: