KSP-TaxiService / CommNetConstellation

A KSP add-on that transforms the CommNet network of single type into multiple constellations of different types
GNU General Public License v3.0
8 stars 8 forks source link

Fix focusEye button #12

Closed cake-pie closed 5 years ago

cake-pie commented 5 years ago

This hotfixes the button texture issue but you might still want to look into why you were doing it like this in the first place.

fixeye

KSP-TaxiService commented 5 years ago

:x: Build CommNetConstellation 1.3.2-60-develop failed (commit https://github.com/KSP-TaxiService/CommNetConstellation/commit/1ecc7a539d by @cake-pie)

cake-pie commented 5 years ago

Oh, and for this issue: https://github.com/KSP-TaxiService/CommNetConstellation/blob/05b2af2c51c75921747d93f8ff84728956319d62/src/CommNetConstellation/UI/ConstellationControlDialog.cs#L47-L51

I don't have a mac to reproduce / test but you can try the workaround of blitting the texture to a temporary RenderTexture, which I've used successfully here and here.

KSP-TaxiService commented 5 years ago

Hi thanks for showing how to disable mipmapping and Mac-specific workaround.

But Unity throws this compression error. Each error happens for all the 4 button textures. image

Do you know anything about this?

cake-pie commented 5 years ago

Hm, see if this does the trick?

KSP-TaxiService commented 5 years ago

:x: Build CommNetConstellation 1.3.2-61-develop failed (commit https://github.com/KSP-TaxiService/CommNetConstellation/commit/af7a9c179d by @cake-pie)

KSP-TaxiService commented 5 years ago

Yah, the error doesn't happen with your latest commit now. :thumbsup:

I will accept your pull request and try out your tricks at larger scope