search

KSP-TaxiService / CommNetConstellation

A KSP add-on that transforms the CommNet network of single type into multiple constellations of different types
GNU General Public License v3.0
8 stars 8 forks source link

MM cfg: FOR -> BEFORE[NearFutureExploration] #22

Closed lampeh closed 4 years ago

lampeh commented 4 years ago

The patch :FOR[NearFutureExploration] runs always and creates the tag "NearFutureExploration", so any other patches that reference NFE in a :NEEDS clause also run, even if that mod is not installed.

KSP-TaxiService commented 4 years ago

:x: Build CommNetConstellation 1.5.3-113-develop failed (commit https://github.com/KSP-TaxiService/CommNetConstellation/commit/7d1776e31a by @lampeh)

lampeh commented 4 years ago

On second thought, just matching ModuleDataTransmitter* (and removing the :NEEDS[!NFE]) in the first patch might be the better solution. It would keep the patch order more predictable, too.

KSP-TaxiService commented 4 years ago

Oops, ModuleManager Handbook and Syntax guide don't specify what FOR does.

I try this change and it seemingly works. @PART[*]:HAS[@MODULE[ModuleDataTransmitter]]:NEEDS[NearFutureExploration]

Is it okay?

KSP-TaxiService commented 4 years ago

:x: Build CommNetConstellation 1.5.3-114-develop failed (commit https://github.com/KSP-TaxiService/CommNetConstellation/commit/b927b6dee8 by @lampeh)

lampeh commented 4 years ago

Is it okay?

It probably would because of the alphabetic ordering of patches.

I edited (and tested) the pull request to match all ModuleDataTransmitter* in one patch. That should avoid any problems with the patch order.

Kerbalism uses the same approach to patch NFE antennas.

KSP-TaxiService commented 4 years ago

Thanks @lampeh!

I will follow Kerbalism's direction on NFE antennas