KSPModdingLibs / KSPCommunityFixes

Community patches for bugs in the KSP codebase.
https://github.com/KSPModdingLibs/KSPCommunityFixes/releases/latest
57 stars 19 forks source link

Autostruts can cross unlocked servo parts #127

Open gotmachine opened 1 year ago

gotmachine commented 1 year ago

Following investigations on issue #96 :

The stock autostrut logic is supposed to prevent autostruts from crossing an unlocked servo, which is perfectly sensible. However, this only applies to childs or parents of the servo part.

Autostruts originating from the servo itself are allowed to cross the servo joint. Depending on the placement of the servo and autostrut target, this can result in the autostrut joint crossing the servo joint and counteracting the servo ability to move :

https://user-images.githubusercontent.com/24925209/227314352-951a2ea3-87e6-4bf0-8c30-d7c47fec1df0.mp4

Strangely, this only is an issue when the autostrut target is a child part. When it's a parent part, the autostrut seems to be continuously updated when the servo move :

https://user-images.githubusercontent.com/24925209/227315312-920f99bd-a1da-4555-94af-ae59fad66f8f.mp4