KSPModdingLibs / KSPCommunityFixes

Community patches for bugs in the KSP codebase.
https://github.com/KSPModdingLibs/KSPCommunityFixes/releases/latest
57 stars 19 forks source link

Exception spam related to OnMouseUp() prevents clicking anything in editor #171

Closed x13x54 closed 10 months ago

x13x54 commented 10 months ago

Describe your problem with KSPCF : After a while in the editor, lots of exceptions spam my screen and log. Just as i was moving a control surface into place using offset. image This issue occurs both on 1.32.0 and 1.32.1. While the exceptions are happening, it becomes almost impossible to click anything as something goes terribly wrong with the OnMouseUp() event. It might have something to do with me using the offset tool. As that is when this becomes noticeable. The click-issue is not permanent and it is possible to "sneak through" a click event every once in a while, switching between place and offset mode does seem to improve things a little.

KSP version : 1.12.5 Link to your KSP.log file : KSP.log

x13x54 commented 10 months ago

Simply clicking the save buttons also appears to throw the same kind of exceptions. I've also found that just spam-clicking nothingness in the editor will let you perform an unhindered click

gotmachine commented 10 months ago

I have some doubts this has anything to do with KSPCF. The exceptions you're getting are related to some other mod, not sure which, but something that has PAW options like "kick mode", "target apogee", "cut at apogee", "target apside" ?

TBH, your log is littered with errors coming from everywhere, installing 300 mods is usually not gonna end well. Could you uninstall KSPCF ? Assuming you can reproduce that issue consistently, I'm pretty sure you will get the exact same issue without it.

Edit : yeah, as I suspected, this is caused by the "BenjisHardwiredLogic" mod, and reproduce even without KSPCF installed, as soon as you have a decoupler or an engine on a craft (that mod is adding its buggy module to every decoupler and engine).

x13x54 commented 10 months ago

I see. I tried without KSPCF and i haven't noticed the same issue. Maybe it's through KSPCF that the other mod's issue becomes noticable, or i haven't reached the same condition yet

gotmachine commented 10 months ago

See https://github.com/ErinaceusLinnaeus/BenjisHardwiredLogic/issues/2