KSPModdingLibs / KSPCommunityFixes

Community patches for bugs in the KSP codebase
49 stars 17 forks source link

FlightIntegrator and friends micro-optimization #230

Open gotmachine opened 3 months ago

gotmachine commented 3 months ago

This is ongoing work to micro-optimize the various heavy duty stuff in FlightIntegrator, VesselPrecalculate and possible other flight scene low level components. The focus is on improving performance scaling in large part count situations, mainly by micro-optimizing the per-part work done in these component.

The optimizations are meant to keep behavior as close to stock as possible, but they do introduce minor changes, and given how critical the patched methods are, any bug or behavior change is likely to have dire cascading consequences, so this will need some testing before being pushed.

As of now, there are a few other areas I want to look at before considering pushing this to a (pre)release, but I won't have much time to commit in the next weeks, not sure when I will resume working on this.

Here is a preview release : KSPCommunityFixes_FlightPerf.zip

JonnyOThan commented 2 months ago

I think there's some kind of issue related to the camera anchor point. This started happening after I installed this build in tpksp: https://clips.twitch.tv/ModernBusyLemurTinyFace-fvxZ_jtUEAGkjCZc

Possibly involving docking or loading a save.

R-T-B commented 1 month ago

I think there's some kind of issue related to the camera anchor point. This started happening after I installed this build in tpksp: https://clips.twitch.tv/ModernBusyLemurTinyFace-fvxZ_jtUEAGkjCZc

Possibly involving docking or loading a save.

I may have seen this as well. On the vessel in question, do you also have where you can't get back to the spacecenter via the top menu, but only via esc menu and such?

JonnyOThan commented 1 month ago

do you also have where you can't get back to the spacecenter via the top menu, but only via esc menu and such?

To be honest I haven't investigated at all and this has only been reported in TPKSP where we don't use the mouse or normal GUI :p

R-T-B commented 1 month ago

Ah, well those are my symptoms when this bug strikes, at any rate.