search

KSPModdingLibs / KSPCommunityFixes

Community patches for bugs in the KSP codebase
49 stars 17 forks source link

Duplicated textures where one is an unsupported format (e.g. DXT3) will fail to load the supported one #237

Open JonnyOThan opened 2 months ago

JonnyOThan commented 2 months ago

https://forum.kerbalspaceprogram.com/topic/204002-18-112-kspcommunityfixes-bugfixes-and-qol-tweaks/?do=findComment&comment=4404427

Kerbal Aircraft Expansion has a few duplicated textures where one is a png and the other is dxt3. Without KSPCF, the game tries to load the dds first, fails, and then successfully loads the png and things work. With KSPCF, it fails on the dxt3 but then does not load the png (it spits out the "duplicate png texture" log message).

Lisias commented 2 months ago

Uh, IMHO, this is not a bug, but an enhancement.

The bug is on KAX. Being able to detect the bug, IMHO, would be an enhancement to KSPCF.

JonnyOThan commented 2 months ago

Well, one of the pillars of KSPCF is that it should match stock behaviors (other than bug fixes) as closely as possible. I don’t think there’s much of a downside to making sure that a failed dds load doesn’t prevent the png from being loaded. This is especially important considering that mods that are affected by this likely aren’t getting any additional updates (or else why would they be using dxt3?) and the error messages will be in the logs whether KSPCF is installed or not