search

KSPModdingLibs / KSPCommunityFixes

Community patches for bugs in the KSP codebase.
https://github.com/KSPModdingLibs/KSPCommunityFixes/releases/latest
59 stars 20 forks source link

CollisionEnhancerFastUpdate can spew NREs with certain other mods #282

Open JonnyOThan opened 3 weeks ago

JonnyOThan commented 3 weeks ago

I don't have many details but I opened the console to see that there were NREs spewing and it looks like it's the collision enhancer patch. I have Firefly and parallax continued installed which may be related.

[EXC 22:26:28.704] NullReferenceException: Object reference not set to an instance of an object
    KSPCommunityFixes.Performance.CollisionEnhancerFastUpdate.CollisionEnhancer_FixedUpdate_Prefix (CollisionEnhancer __instance) (at <e997dbbd4fda4eacb68a00719aa5e5dc>:0)
    (wrapper dynamic-method) CollisionEnhancer.CollisionEnhancer.FixedUpdate_Patch1(CollisionEnhancer)
    UnityEngine.DebugLogHandler:LogException(Exception, Object)
    ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
    UnityEngine.Debug:CallOverridenDebugHandler(Exception, Object)
gotmachine commented 3 weeks ago

A bit of context (and the full log) could help... Happening continuously or on some event / specific situation ?

But likely this is because I removed the null check for the part, or because I'm accessing the vessel.

OrbitalManeuvers commented 1 week ago

Here's a folder with a full log and settings.cfg. Launching fireworks triggers this nullref spam until firework explodes.

https://drive.google.com/drive/folders/1idtJw9CxYYnJIMz4ShxlM8wiTUYy87Aw?usp=sharing