search

KSPP / linux

Linux kernel source tree (Kernel Self Protection Project)
https://kernsec.org/wiki/index.php/Kernel_Self_Protection_Project
Other
81 stars 5 forks source link

arch/powerpc/platforms/85xx/mpc85xx_cds.c:161:3: warning: unannotated fall-through between switch labels #198

Closed kees closed 1 year ago

kees commented 2 years ago

Missing "break" before "default" switch case:

749e80810d26c8 Roy Zang       2007-06-01  153           /* There are two USB controllers.
749e80810d26c8 Roy Zang       2007-06-01  154            * Identify them by functon number
749e80810d26c8 Roy Zang       2007-06-01  155            */
8d7bc8f9d1c23f Randy Vinson   2007-07-19  156                   if (PCI_FUNC(dev->devfn) == 3)
749e80810d26c8 Roy Zang       2007-06-01  157                           dev->irq = 11;
749e80810d26c8 Roy Zang       2007-06-01  158                   else
591f0a4287d0de Andy Fleming   2006-04-02  159                           dev->irq = 10;
749e80810d26c8 Roy Zang       2007-06-01  160                   pci_write_config_byte(dev,
PCI_INTERRUPT_LINE, dev->irq);
749e80810d26c8 Roy Zang       2007-06-01 @161           default:
749e80810d26c8 Roy Zang       2007-06-01  162                   break;

https://lore.kernel.org/lkml/202209061224.KxORRGVg-lkp@intel.com

GustavoARSilva commented 2 years ago

I just sent out a patch for this: https://lore.kernel.org/linux-hardening/Yxe8XTY5C9qJLd0Z@work/