search

KSoft-Si / ksoftapi.py

Official API Wrapper for KSoft.Si API
https://api.ksoft.si/
GNU General Public License v3.0
31 stars 9 forks source link

LyricResult missing url attribute #11

Closed abdelrahmanyr closed 4 years ago

abdelrahmanyr commented 4 years ago

The LyricResult object does not have url attribute which gives the lyrics link.

GamingGeek commented 4 years ago

Is this PR meant to add the attribute? If so, I don't think you know how pull requests work since you're trying to merge existing commits into master which are unrelated to the topic of this PR.

uKaigo commented 4 years ago

I already added this attribute in #10

uKaigo commented 4 years ago

And as GamingGeek noted, that's not the point of the PR

abdelrahmanyr commented 4 years ago

Yes I don't know really know how pr works, should I delete it ?

uKaigo commented 4 years ago

You just described your PR with a thing that you didn't changed.

You should've described with something like "Sync fix/response-code with master"

And I'm unsure, but I think that branch isn't supported anyway.