KSunil2001 / pe

0 stars 0 forks source link

Two clients with the same mobile number #4

Open KSunil2001 opened 1 year ago

KSunil2001 commented 1 year ago

image.png

Steps to reproduce:

  1. Run the jar file
  2. Update any client's mobile number to have the same mobile number as another existing client in the system. In my case, I used uc -e royb@example.com -mn 92492021

Expected: Error message saying, "Client exists with this mobile number"

Actual: Two clients share the same mobile number

The screenshot above shows the clients "Irfan Ibrahim" and "Roy Balakrishnan" having the same mobile number "92492021".

nus-pe-bot commented 1 year ago

Team's Response

It is possible that two clients can have the same mobile number. For instance, if it was a company that commissioned the project, you could have multiple points of contact with the company with each being a client. However, the mobile number given could be the company’s office number which will lead to all points of contact sharing the same number. It is true the same can be argued with regards to email, however, it was a design choice for us to utilise email as the unique identifier of clients instead of mobile number. Hence, we believe that this is NotInScope.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I agree that your reasoning for having a company's office number can be the same for multiple points of contact sharing the same number. However, this does not rule out the possibility of sharing mobile numbers that are not company's office numbers, as there are no validity checks in place to prevent this from happening.

I also feel that the severity should be High as I did not have enough time to think about assigning the severity of the issues during the PE itself. The severity should be High because, having different clients with the same mobile number can cause confusion when trying to contact the client. This mobile number may or may not be the company's office number being shared by both clients, as there are no validity checks in place to confirm this.