nus-pe-bot
commented
3 years ago Team's Response
No details provided by team.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Duplicate telegram and/or github not detected
The
addcommand doesn't work as expected. It should not allow duplicate persons, but I can add a new student with a different name but same telegram and github as my own.I think this situation is rare, because not many people want to steal the telegram and/or github username of other people. But there can be the case where 2 students have handles that are almost identical and the user made a typo when adding new person, resulting in duplicates.
[original: nus-cs2103-AY2122S1/pe-interim#927] [original labels: severity.Low type.FunctionalityBug]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
The duplicates are not allowed in the contacts list, but the user can be present in the contact list.
When the professor would provide you with a contacts list of all students in the mod, it would contain your details.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [ ] I disagree
Reason for disagreement: [replace this with your reason]
:question: Issue response
Team chose [response.Rejected]
- [ ] I disagree
Reason for disagreement: [replace this with your reason]
Currently the app allows me to edit the user profile with key client fields (telegram, github username) that are the same as existing contacts in the app. I am not sure whether this is intended as it is not stated in the UG however I believe that this might result in the user facing issues when the user's own fields is closely similar to existing contacts.