search

KTH-dESA / OSeMBE

OSeMBE - model, data, and scripts
Other
0 stars 6 forks source link

A python script for decoding OSEMBE codes #6

Open Timon-R opened 10 months ago

Timon-R commented 10 months ago

I wrote a python script that can be used to decipher OSEMBE codes of technologies and fuels. You can access it here: Code Decipherer

HauHe commented 10 months ago

Nice, addition @Timon-R! Perhaps we should link to it in the README here: https://github.com/KTH-dESA/OSeMBE/blob/v1.0.0/README.rst And in the explanation of the naming convention in the documentation, i.e., here: https://osembe.readthedocs.io/en/latest/naming.html Would you mind making these additions on your fork and creating pull requests?

Timon-R commented 10 months ago

Thank you @HauHe

the context in which I created this script is that I am working on my Master's thesis in which I investigate the hydrogen layer of the Nordic energy system. So I used the OSeMBE_ECEMF as a base for my model and then modified it to only include one scenario (WP1_NetZero) and the Nordic countries (DK,FI,NO,SE). I also modified other scripts so that it works. While I will certainly link it to the OSeMBE model once it is working and ready to be published, I don't know how creating a pull request to the main OSeMBE model can make sense.

One thing I could do now is to create a fork of the OSeMBE model independend of the Nordic model I am working on and create a pull request for the changes mentioned (the deciphering script as well as the naming convention). Does that make sense or do you have another idea? I am not very experienced with GitHub yet so I appreciate your view on it.

HauHe commented 10 months ago

Hi @Timon-R ,

thanks for the context! Good that you're asking before doing something. But your suggestion to at the end sounds good. Because for the Nodric model you cloned and/or forked the repo OSeMBE_ECEMF right? Whereas the links in the README and the documentation need to be added to the OSeMBE repo. Hence, yes, fork that and make the pull request from there.

Timon-R commented 10 months ago

Alright, done so