search

KTManager / Legacy-KTManagerApp

The Legacy multi-platform mobile application for Kill Team Manager
GNU General Public License v3.0
12 stars 4 forks source link

Issue #85 Adds team points picker #127

Closed sklarsa closed 4 years ago

sklarsa commented 4 years ago

With preset options to choose 100, 125, or 200 points for Core, Elites, or Commander

sklarsa commented 4 years ago

Fixes https://github.com/KTManager/KTManagerApp/issues/85

sklarsa commented 4 years ago

Oh oops, not sure how that got deleted. I’ll run some more testing myself later today

On Jul 19, 2020, at 9:44 AM, Jonny Olliff-Lee notifications@github.com wrote:

@DevJonny commented on this pull request.

All looks good code wise. Don't have time to test it manually so I'll trust that you have :)

The only thing I wanted to flag is that KillTeam/Properties/Resources.Designer.cs has been deleted. Was this intentional?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

sklarsa commented 4 years ago

Looking now, it's just a large diff that was not rendered. The file still exists

sklarsa commented 4 years ago

Updated with a bug fix, so newly created teams are set to 100 points by default. Also internationalized text.

DevJonny commented 4 years ago

Looks good @sklarsa squash and merge when you're ready

DevJonny commented 4 years ago

Looking now, it's just a large diff that was not rendered. The file still exists

Ah my bad, just saw the red bars but didn't load the diff.

sklarsa commented 4 years ago 
This branch has no conflicts with the base branch
Only those with write access to this repository can merge pull requests.
DevJonny commented 4 years ago

Done, thanks @sklarsa