search

KTS915 / Test-ClassicPress-Directory

GNU General Public License v3.0
0 stars 0 forks source link

Add notice-error class to 2FA notice #3

Closed viktorix closed 2 years ago

viktorix commented 2 years ago

I couldn't find it in the repo code, but I do see it on the demo website. We should add either notice-error or notice-warning to the 2FA notice, so it stands out more. I would go with error/red because it is a required step, and for this reason, I would also remove is-dismissable.

image

KTS915 commented 2 years ago

The code is in registration-users.php in mu-plugins.

It's not an error, so it shouldn't be notice-error, and notice-warning actually makes it show up less than the current notice, so I don't agree with either of these suggestions. I'm also not sure how anyone could miss it as it is, because it's quite large as the font size is set to 150%. Screenshot from 2022-07-21 16-43-08

I'll never agree with removing is-dismissible either. That's just bad manners. The notice comes back when the page is refreshed anyway, but if someone wants to get rid of it temporarily for some reason (e.g. to have more screen real estate) then they should be able to do so.

viktorix commented 2 years ago

Then notice-info should be the right option.

KTS915 commented 2 years ago

Now done via commit referenced above.