search

KTS915 / Test-ClassicPress-Directory

GNU General Public License v3.0
0 stars 0 forks source link

Fix description if README.md is not found in the repo #32

Closed xxsimoxx closed 2 years ago

xxsimoxx commented 2 years ago

If README.md is not found $readme['body'] is not empty but a "not found" message.

xxsimoxx commented 2 years ago

We should also consider to remove parsing the README.md at that point. My opinion is that is better to check the one in the zip file (that is already implemented), as the one in the repo could refer to functionality that is being implemented in the default branch and not already in a release.

KTS915 commented 2 years ago

Good catch on the message.

I've been thinking about your other point. Is is likely that a developer would have the README.md file say something different from what's in the software when they've just made a new release? What's bothering me particularly is that releases have to be done manually, so the developer might not even include the README.md file in the zip file. I suppose we could have it as the fallback instead of the first option.

xxsimoxx commented 2 years ago

I suppose we could have it as the fallback instead of the first option.

Agree!