ENH: convert Ziprev and SumGDDPrev

KUL-RSDA / AquaCrop

AquaCrop source code endorsed by FAO

https://www.fao.org/aquacrop/en/

Other

56 stars 17 forks source link

ENH: convert Ziprev and SumGDDPrev #254

Closed gdelannoy closed 2 years ago

gdelannoy commented 2 years ago

This passes all tests and is a re-instatement of PR#250 minus the removal of an unused temporary variable (removing the unused variable would cause a failing test)...

MaximeVdB commented 2 years ago

@MaximeVdB @lbusschaert: removing this temporary (and unused) variable "PreviousSum_temp" causes the perennial test to fail. Just highlighting it here, b/c this makes no sense to me.

I can reproduce this, and I'm also amazed! I don't know if there is much we can do about this at this stage. But when converting the InitializeRun() procedure, this is something to keep in mind.