KUL-RSDA / AquaCrop

AquaCrop source code endorsed by FAO
https://www.fao.org/aquacrop/en/
Other
56 stars 17 forks source link

Post-conversion cleanup #295

Closed MaximeVdB closed 2 years ago

MaximeVdB commented 2 years ago

Now that the translation is finished, it was time for some cleanup/restructuring.

The most noticeable changes are:

Edit: the full testsuite now passes for both DEBUG=0 and DEBUG=1, both in the Singularity image and with foss-2018a. This was done with the (now-default) FORTRAN_EXE=1 option. For the FORTRAN_EXE=0 option, the same combinations were tested, but only for the Harvest test (this is OK since the Fortran-Pascal coupling is now reduced to a trivial StartTheProgram() call).

mbechtold commented 2 years ago

Forget my last comment. Of course, Europe test still missing. Saw also you merged the getters and setters already into this branch. Will use this for the LIS coupling now.

MaximeVdB commented 2 years ago

As you can see in 673522f, there was still one failure for the Harvest test, but only for DEBUG=0 and with the Singularity image. That one is also solved now (though the real cause rather seems to be a bug in the v10.2.1 gfortran compiler).