search

KUL-RSDA / AquaCrop

AquaCrop source code endorsed by FAO
https://www.fao.org/aquacrop/en/
Other
54 stars 17 forks source link

ENH: splitup_InitializeSimulationRun #299

Closed mbechtold closed 2 years ago

mbechtold commented 2 years ago

To have a separate routine to initialize the climate ("InitializeClimate"), InitializeSimulationRun was split into two parts. Between those two parts, the new routine InitializeClimate is called. In LIS this is the moment in which the LIS input is acquired to initialize the climate.

mbechtold commented 2 years ago

Small Europe and Perennial tests passed. Also used already successfully in LIS.

MaximeVdB commented 2 years ago

Looks good -- so maybe just add some short description at the newly created procedures (InitializeClimate, InitializeSimulationRunPart2, InitializeRunPart2) to make clear what is happening in them:

subroutine InitializeClimate()
    !! Docstring comes here. 

    ...
mbechtold commented 2 years ago

Thanks. I added a short description.

MaximeVdB commented 2 years ago

Thanks. I added a short description.

OK -- just one more thing regarding spacing: I would like to see no empty lines between a docstring and the declaration of the procedure arguments. And after that, always one empty line (as usual). And also one empty line after the declaration of the local variables, if present (as usual).

mbechtold commented 2 years ago

Alright. Done.

mbechtold commented 2 years ago

Makes sense. Sorry. Fixed.