KUL-RSDA / AquaCrop

AquaCrop source code endorsed by FAO
https://www.fao.org/aquacrop/en/
Other
56 stars 17 forks source link

HOLD: Optional crop and soil files (only for NASA-LIS-AquaCrop coupling) #301

Closed MaximeVdB closed 2 years ago

MaximeVdB commented 2 years ago

This PR intends to make 'crop' and 'soil' files optional (by specifying them as (None) in the PRM/PRO file) and in this way allow external programs like LIS to set crop- and soil-related parameters directly (without needing to write input files which would then be read in by AquaCrop).

mbechtold commented 2 years ago

Looks good to me, only Zrni seems not be set for external use. I think also LoadCrop needs to a split up into LoadCrop and LoadCropProcessing, e.g. this is a processing step after input reading. call SetCrop_CCo((GetCrop_PlantingDens()/10000._dp) &

mbechtold commented 2 years ago

The LoadProfileProcessing works nicely with LIS when working around the above issues (hardcoded version number and added GravelVol part). Will check the LoadCropProcessing later today!

MaximeVdB commented 2 years ago

(Marking as WIP since we're postponing the testing of the crop part)