License and final model updates

KUL-RSDA / AquaCrop

AquaCrop source code endorsed by FAO

https://www.fao.org/aquacrop/en/

Other

56 stars 17 forks source link

License and final model updates #308

Closed MaximeVdB closed 2 years ago

MaximeVdB commented 2 years ago

This PR adds basic license info as well as the latest scientific model updates.

Todo:

[x] First #307 needs to be merged.
[x] Add alfalfa-related changes when they become available.
[x] The present changes lead to small changes in the outputs (up to a few least-significant digits in both Europe and Perennial tests). We should here double-check the source code changes and then (1) regenerate the reference outputs accordingly if the changes are indeed correct (2) run the whole testsuite for the different build types.

MaximeVdB commented 2 years ago

Can you also add a file with "Software development" (with all of our contributors names) and a "References" (2 KU Leuven publications, one by Louise, one by SHannon)? I will send them to you via e-mail together with the instructions from our KU Leuven advisors.

There's now an AUTHORS.md file (badc2a9ab1ac7196d9ee585acc85d13df7711d0f). Please check if there more (non-KU-Leuven?) people to add to the list.

MaximeVdB commented 2 years ago

Update: I have now re-generated the reference outputs with gfortran from the foss-2018a toolchain and DEBUG=1 FORTRAN_EXE=1. The aquacrop_tests folder in your /staging folder now contains these new references. I moved the previous aquacrop_tests folder to aquacrop_tests_2022-08-02, as usual. Could you check that this updated test directory together with the current branch?

I myself got the whole testsuite to pass, i.e. with

DEBUG=1 FORTRAN_EXE=1 and DEBUG=0 FORTRAN_EXE=0 for FC=gfortran with both the foss-2018a toolchain and the Singularity image.
DEBUG=1 and DEBUG=0 (both with FORTRAN_EXE=1) for FC=ifort with the intel-2018a toolchain.

mbechtold commented 2 years ago

I ran what you requested for DEBUG=0/1 and FORTRAN_EXE=1 with the Singularity image. It passed.