KULL-Centre / PRISM

Software development pipelines related to the PRISM project
8 stars 4 forks source link

Treatment of missing non-heavy, side-chain atoms #6

Closed j0kaso closed 2 years ago

j0kaso commented 4 years ago

Are they treated during the relax step (automatically)? It would be good to add this info to "the" documentation.

amelie-stein commented 4 years ago

I'm not sure I understand the question. They are missing, and there is no simple way to fill them in. Constrained relax has per-atom constraints so this should not matter. For unrelaxed constraints we should look into what happens, I am not sure. But missing atoms are common so I suspect there is a reasonably safe default - but best check on well-known examples. We can also chat about it later.

j0kaso commented 4 years ago

Clarification: it's about missing non-heavy, side-chain atoms

Some ideas with regards to this:

amelie-stein commented 4 years ago

Since Rosetta will always rebuild the missing atoms, I don't think you need that last check. Also keep in mind that all this is rather specific to crystal structures, but a large part of our likely "application targets" are homology models, where everything will have been built by Rosetta - heavily inspired by experimental structures, yes, but all the details such as side chains will have been placed by Rosetta.

j0kaso commented 4 years ago

listening a bit to some Rosetta community conversations, we should add a check to see that modeled side-chains do not contain clashes. I guess Rosetta is printing this out, so we could just re-use that?

amelie-stein commented 4 years ago

I think this will be addressed by the relax step, between the repacking and minimisation that it does. Or is this a concern being discussed post-relaxation?

j0kaso commented 4 years ago

it still is not resolved (in some cases) post-relaxation. I would just make everyone aware of it (& maybe be able to catch the error automatically) and then see how often this happens & evaluate then how we can improve this.

amelie-stein commented 4 years ago

Ok thanks. I do think this would implicitly be covered if we keep per-residue energies, especially if we also keep partial sfxn terms (fa_rep in this case).

j0kaso commented 2 years ago

Notes added in 1ddabfb8afd0d8483c843169f4028cf05fcc1fb8