search

KULeuven-MICAS / snax-mlir

Driving Snax with MLIR
https://kuleuven-micas.github.io/snax-mlir/
Other
12 stars 3 forks source link

kernels: return 1 on error #259

Closed jorendumoulin closed 1 week ago

jorendumoulin commented 1 week ago

Right now, the kernels return the number of errors in main.c. However, this seems to cause some kernels succeeding in CI even though they are wrong. For example, upon returning 256, CI will not fail.

Examples:

Succeeding test when returning 256: https://github.com/KULeuven-MICAS/snax-mlir/actions/runs/11012247027/job/30578039634 Failing test when returning 1: https://github.com/KULeuven-MICAS/snax-mlir/actions/runs/11012262776/job/30578088724

This PR just makes sure all kernels return 1 if an error occurs

jorendumoulin commented 1 week ago

Nice! But you seem to have forgotten a few kernels? how about alloc, rescale, ...? Can you also update the benchmarks then?

sure! I just took the list of kernels from ci, rescale did not exist back then, but alloc seems to not be included in ci lol?

jorendumoulin commented 1 week ago

and the alloc kernel does not even work :'(, I'll make an issue for this one