search

KULeuven-MICAS / snax_cluster

A heterogeneous accelerator-centric compute cluster
Apache License 2.0
10 stars 9 forks source link

Xyi/sw clean gemmx dr #275

Closed xiaoling-yi closed 2 months ago

xiaoling-yi commented 2 months ago

Redundant software code is removed here following this PR: https://github.com/KULeuven-MICAS/snax_cluster/pull/270, including snax-gemm, snax-streamer-gemm, snax-streamer-simd, snax-streamer-gemm-add-c, snax-streamer-conv. These libs are now merged into the snax-streamer-gemm-conv-simd.

xiaoling-yi commented 2 months ago

OK!

Are sure the other library files are not needed on your side anymore? This is totally fine with me 😄

Yes, useful c functions are moved to the snax-streamer-gemm-conv-simd lib!

jorendumoulin commented 2 months ago

Where is the set_block_gemm_csr now?

xiaoling-yi commented 2 months ago

Where is the set_block_gemm_csr now?

It is removed. Now there is only one set_gemmx_csr for setting the csrs for the gemmx. Is anywhere the set_block_gemm_csr still be used on your side?

jorendumoulin commented 2 months ago

Yes, i thought we were going to keep streamer-gemm and streamer-gemm-add-c for a little while until our tests have moved to the gemmx?

xiaoling-yi commented 2 months ago

Ok, I thought there was no one using it. Can you add whatever you need back? Since some useful functions have already been moved to snax-streamer-gemm-conv-simd from the streamer-gemm. Basically, I cleaned all the dead code that is not used in the current software test.