KULeuven-MICAS / snax_cluster

A heterogeneous accelerator-centric compute cluster
Apache License 2.0
11 stars 10 forks source link

Add channel mask for add-c port in gemmx #347

Closed xiaoling-yi closed 2 months ago

xiaoling-yi commented 2 months ago

In this PR, we add the support for the channel musk for gemmx's add-c support:

jorendumoulin commented 2 months ago

Hi, looking good!

I just have two questions:

- the name configurable_channel, seems very unclear. Does has_broadcast make more sense? As in the streamer allows to broadcast the input of one tcdm port to all ports? - Do we need to add an extra csr? Can't we just enable the broadcast by programming 0 to spatialstride? (=every port fetches the same data, so broadcast must be enabled, and channels masked)

edit: i misunderstood still, the naming is a bit confusing. has_channel_mask makes much more sense to me

xiaoling-yi commented 2 months ago

has_channel_mask makes much more sense to me

The parameter name is a historical legacy. I will discuss it with Yunhao to see how to solve it.