search

KULeuven-MICAS / stream

Multi-core HW accelerator mapping optimization framework for layer-fused ML workloads.
https://kuleuven-micas.github.io/stream/
MIT License
34 stars 17 forks source link

AcceleratorParserStage is not compatible with Stream Accelerator objects #10

Closed Andful closed 7 months ago

Andful commented 1 year ago

Currently, stream uses the zigzag AcceleratorParserStage stage, which either accepts a string or a ZigZag's Accelerator object. If the field accelerator is a ZigZag's Accelerator, then the stage finishes without errors but later stages error out. If a Stream's Accelerator object is passed, the stage does not recognize such object as an Accelerator.

asyms commented 10 months ago

Hi @Andful,

Is this still a problem or can I close this issue?

Andful commented 10 months ago

I personally steered away from using an accelerator object and have been using accelerators defined in a separate path. So, to answer your question, personally it has not been an issue for me.

asyms commented 7 months ago

This has been fixed in a recent ZigZag update