search

KULeuven-MICAS / zigzag

HW Architecture-Mapping Design Space Exploration Framework for Deep Learning Accelerators
https://kuleuven-micas.github.io/zigzag/
MIT License
104 stars 36 forks source link

Error dimensions parse in ConvParser()? #13

Closed cnjsdfcy closed 1 year ago

cnjsdfcy commented 1 year ago

Hi,

As in below code segment, shouldn't the IX = ia_shape[3], IY = ia_shape[2]? Also W/O should be NCHW layout in ONNX.

https://github.com/KULeuven-MICAS/zigzag/blob/de6d4bbecec8cbb1f108ad2ed379ab7cfef01d0a/zigzag/classes/io/onnx/conv.py#L88C1-L94C33

Thanks, Jason

asyms commented 1 year ago

Fixed in https://github.com/KULeuven-MICAS/zigzag/commit/9795495394aadc6390a5528750797413f2525831