Closed RobinGeens closed 1 month ago
This is a perfect list of how this PR had to be split up 🥲 . Right now, if someone disagrees with a certain part, it's very hard to filter it out. It is also very difficult to see what diff corresponds to what feature change.
Agreed, will keep this in mind next PR :)
Not everybody uses VSCode :), if you want to enforce type checking, I suggest adding the pyright configuration (which can be detected by VSCode) in the
pyproject.toml
Fair point, thanks for the remark!
This branch holds many many changes to the internals of Zigzag, though the functionality itself has barely changed. Changes include the following:
CumulativeCME
classThe proposed dev setup, to be used by all future contributions, is as follows:
.github/workflows/
. This is the one from the Google style guide, but with a line length of 120"python.analysis.typeCheckingMode": "strict",
in.vscode/settings.json
To complete this PR, the following to do's should be completed. Currently, only the
test_origin
tests pass.PEArrayScalingStage.py
,SearchUnusedMemoryStage.py
,RemoveUnusedMemoryStage.py
,GeneralParameterIteratorStage.py
,AimcArray.py
,DimcArray.py
,imc_unit.py
,ImcArray.py
test_origin
To come to a more uniformly programmed code base, I would like to suggest the following programming principles:
Note that after this PR, I will be reworking the user interface.