search

KVM-VMI / kvm

Fork of KVM with Virtual Machine Introspection patches
Other
33 stars 28 forks source link

kvmi: increase the message size #25

Closed adlazar closed 4 years ago

adlazar commented 4 years ago

This will allow us to read a whole page with KVMI_READ_PHYSICAL.

Signed-off-by: Adalbert Lazăr alazar@bitdefender.com

mtarral commented 4 years ago

@adlazar could you explain this modification, because it's not obvious to me why we are introducing a magic number * 2 to increase the message size ?

adlazar commented 4 years ago

For convenience, we've tried to keep the message limit small and page size multiple (including the message header). The variable size commands and command replies are affected by this limit. The old value (one page size minus the message header) won't allow us to read (or write) a whole page, which is a common use case, I guess.

mtarral commented 4 years ago

@adlazar can i merge this, or do you need more eyes/testing on it ?

adlazar commented 4 years ago

You can merge it, but you need it in userspace (libvmi) too.

Wenzel commented 4 years ago

I forgot about this one, merging now.