KVSlab / VaMPy

A collection of tools for pre-processing, simulating, and post-processing vascular morphologies.
https://kvslab.github.io/VaMPy
GNU General Public License v3.0
15 stars 8 forks source link

modify dependency #118

Closed keiyamamo closed 1 year ago

keiyamamo commented 1 year ago

Hi,

We would like to use vampy without installing oasis, morphman (vmtk) for our FSI framework, but currently it is not possible. Therefore, I modified some of the __init__.py files so that we can use vampy without these packages. There might be better way to do this, so please let me know if you have any suggestions!

Best, Kei

codecov-commenter commented 1 year ago

Codecov Report

Merging #118 (e094ea5) into master (91605ba) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   95.52%   95.52%           
=======================================
  Files           5        5           
  Lines         201      201           
=======================================
  Hits          192      192           
  Misses          9        9           
keiyamamo commented 1 year ago

@johannesring Thank you for the comments! They are now fixed :)

hkjeldsberg commented 1 year ago

Think this looks fine, and works as a temporary solution 👍 I can't currently think of any better way to do this.