search

KVSlab / VaSP

A collection of tools for pre-processing, simulating, and post-processing vascular fluid-structure-interaction problems
https://kvslab.github.io/VaSP/
GNU General Public License v3.0
9 stars 4 forks source link

integrate meshing with painted surface into the main meshing script #190

Closed keiyamamo closed 1 month ago

keiyamamo commented 1 month ago

This PR adds functionality to create a mesh with painted surface mesh. Originally developed by @dbruneau-mie in the previous meshing framework and I integrated into the current meshing script.

To use this functionality, users need to have a painted surface mesh with thickness information in it and also need to install pyvista.

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 22.58065% with 24 lines in your changes missing coverage. Please review.

Project coverage is 78.54%. Comparing base (b342bb3) to head (4c1a8cd). Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
.../automatedPreprocessing/automated_preprocessing.py 22.58% 24 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #190 +/- ## ========================================== - Coverage 78.73% 78.54% -0.19% ========================================== Files 32 32 Lines 3743 3841 +98 ========================================== + Hits 2947 3017 +70 - Misses 796 824 +28 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

keiyamamo commented 1 month ago

Hi @johannesring

I modified the script based on your suggestions. Could you please review the code again?

johannesring commented 1 month ago

It looks fine, but it would be good to provide some defaults for the radius and the sharpness. I am not sure what the default radius should be, but you used 0.4 in your original code, so that is probably fine. The default sharpness should probably be 1.0. You can for example add something like the following at the end of the read_command_line function to set the defaults:

# Check if --solid-thickness is 'painted' and set default values accordingly
if args.solid_thickness == "painted" and args.solid_thickness_parameters == [0.3]:
    args.solid_thickness_parameters = [0.3, 0.4, 1.0]

And maybe add something like this to the help text for the --solid-thickness-parameters option:

"Defaults: [0.3] for 'constant', [0.3, 0.4, 1.0] for 'painted'."
keiyamamo commented 1 month ago

Hi @johannesring,

Thank you again for the comments. I addressed your suggestions. Please let me know if it looks fine.