search

KWARC / rust-libxml

Rust wrapper for libxml2
https://crates.io/crates/libxml
MIT License
76 stars 38 forks source link

Add MacOS and Windows installation steps to README #89

Closed dginev closed 3 years ago

dginev commented 3 years ago

Hi @hurlenko and @lepapareil ,

Could you take a brief look if adding the installation dependencies to the README in this PR looks reasonable? I've kept references in so that people can track the original discussions as well, when necessary.

Thanks again for contributing these, and I hope folks find them helpful.

lepapareil commented 3 years ago

Ok for windows 👌

hurlenko commented 3 years ago

Looks good to me 🙂. Also the chocolatey steps seem to be optional, and are only meant to be used to install rust. At least I skipped them and compiled libxml on Windows successfully:

C:\> choco install -y curl git unxUtils winlibs-llvm-free
C:\> refreshenv
C:\> %ChocolateyInstall%\bin\curl --output "c:\rustup-init.exe" "https://static.rust-lang.org/rustup/dist/i686-pc-windows-gnu/rustup-init.exe"
C:\> c:\rustup-init.exe -y --default-toolchain stable-x86_64-pc-windows-msvc

Thanks!

dginev commented 3 years ago

Good point, I can trim it down a bit further. The new instructions will go to crates.io with the nest release, thanks both for the quick reviews 👍🏻