KWB-R / kwb.fakin

Functions Used in Our FAKIN Project
http://kwb-r.github.io/kwb.fakin
MIT License
1 stars 0 forks source link

Installation fails due to pkg dependency circle? #11

Open mrustl opened 5 years ago

mrustl commented 5 years ago

Please check, maybe related to r-lib/remotes#225 https://github.com/dynverse/dyno/issues/33#issuecomment-447783528

remotes::install_github("kwb-r/kwb.fakin")
Downloading GitHub repo kwb-r/kwb.fakin@master
These packages have more recent versions available.
Which would you like to update?

1:   kwb.code (9dfa99ec0... -> 721d7b0fe...) [GitHub]

Enter one or more numbers separated by spaces, or an empty line to cancel
1: 1
kwb.code (9dfa99ec0... -> 721d7b0fe...) [GitHub]
Downloading GitHub repo kwb-r/kwb.code@master
Downloading GitHub repo kwb-r/kwb.file@master
These packages have more recent versions available.
Which would you like to update?

1:   kwb.fakin (0.3.0 -> e59dd0165...) [GitHub]

Enter one or more numbers separated by spaces, or an empty line to cancel
1: 1
kwb.fakin (0.3.0 -> e59dd0165...) [GitHub]
Downloading GitHub repo kwb-r/kwb.fakin@master
Skipping kwb.fakin, it is already being installed
Error in vapply(remotes, install_remote, ..., FUN.VALUE = character(1)) : 
  values must be type 'character',
 but FUN(X[[1]]) result is type 'logical'
sessioninfo::session_info()
- Session info --------------------------------------------------------------------------------------------------------------------
 setting  value                       
 version  R version 3.5.1 (2018-07-02)
 os       Windows 7 x64 SP 1          
 system   x86_64, mingw32             
 ui       RStudio                     
 language (EN)                        
 collate  English_United Kingdom.1252 
 ctype    English_United Kingdom.1252 
 tz       Europe/Berlin               
 date     2018-12-19                  

- Packages ------------------------------------------------------------------------------------------------------------------------
 package     * version    date       lib source                        
 assertthat    0.2.0      2017-04-11 [1] CRAN (R 3.5.0)                
 cli           1.0.1      2018-09-25 [1] CRAN (R 3.5.1)                
 crayon        1.3.4      2017-09-16 [1] CRAN (R 3.5.0)                
 curl          3.2        2018-03-28 [1] CRAN (R 3.5.0)                
 remotes       2.0.2.9000 2018-12-19 [1] Github (r-lib/remotes@80c9288)
 rstudioapi    0.8        2018-10-02 [1] CRAN (R 3.5.1)                
 sessioninfo   1.1.0      2018-09-25 [1] CRAN (R 3.5.1)                
 withr         2.1.2      2018-03-15 [1] CRAN (R 3.5.0)                

[1] C:/Users/mrustl.KWB/Documents/R/win-library/3.5
[2] C:/Program Files/R/R-3.5.1/library
mrustl commented 5 years ago

Using: remotes::install_github("kwb-r/kwb.fakin",upgrade = "never") works

jimhester commented 5 years ago

The type error should be fixed by https://github.com/r-lib/remotes/commit/a0d6cd5d52062fcaedac7dd19b03f9211f578791

However you cannot have hard circular dependencies (e.g. all in Imports or Depends), one of the dependencies needs to be soft (e.g. in Suggests).

Currently you have kwb.fakin -> kwb.code -> kwb.file -> kwb.fakin all in Imports, so there is no way to install kwb.fakin.

mrustl commented 5 years ago

@jimhester :100: thanks for your detailed answer and fixing the type error!