KWB-R / kwb.pkgbuild

Helper functions for automating R package development at KWB to a predefined style
https://kwb-r.github.io/kwb.pkgbuild
MIT License
2 stars 0 forks source link

use appveyor.yml template (close #37 and #45) #46

Closed mrustl closed 5 years ago

mrustl commented 5 years ago

and start generalising functions (still a lot to clean!)


This change is Reviewable

mrustl commented 5 years ago

R/helper.R, line 228 at r2 (raw file):

Previously, hsonne (Hauke Sonnenberg) wrote…
> ``` > sprintf( > "############################################################################## > ### Autogenerated with R package %s v%s > ### (installed from '%s' source code on %s) > ### by calling the function %s > ### (file created at: %s) > ##############################################################################\n\n", > meta_creation$package, > meta_creation$ondiskversion, > meta_creation$source, > meta_creation$date, > calling_function_name, > Sys.time() > ``` I do not like multiline strings. Better: ``` fmt <- paste(collapse = "\n", c( "line 1", "line 2", )) sprintf(fmt, ...) ```

Done.

mrustl commented 5 years ago

R/git_config.R, line 45 at r1 (raw file):

Previously, mrustl (Michael Rustler) wrote…
Is needed for escaping the "@" in roxygen2 (see: https://stackoverflow.com/questions/8809004/escaping-in-roxygen2-style-documentation)

Done.

mrustl commented 5 years ago

R/git_config.R, line 34 at r1 (raw file):

Previously, mrustl (Michael Rustler) wrote…
Should be Email

Done.

mrustl commented 5 years ago

R/git_config.R, line 31 at r1 (raw file):

Previously, mrustl (Michael Rustler) wrote…
Ops. Forgot to call the `shell()` function

Done.

mrustl commented 5 years ago

R/git_config.R, line 10 at r1 (raw file):

Previously, mrustl (Michael Rustler) wrote…
Great idea! :+1:

Done.

mrustl commented 5 years ago

@hsonne I hope that I fixed the git tests now! Stay tuned and check