git: fix tests on windows

KWB-R / kwb.pkgbuild

Helper functions for automating R package development at KWB to a predefined style

https://kwb-r.github.io/kwb.pkgbuild

MIT License

2 stars 0 forks source link

git: fix tests on windows #47

Closed mrustl closed 5 years ago

mrustl commented 5 years ago

As on Windows git is not on the path the tests fail.

== testthat results  =============================================================
OK: 16 SKIPPED: 8 FAILED: 2
1. Failure: git_setup_user() works (@test-function-git_check_config.R#3) 
2. Failure: git_check_config() works (@test-function-git_setup_user.R#3)

Proposed workaround: We should use the function: https://github.com/KWB-R/kwb.pkgbuild/blob/e5d17cd2c9317ac567a0e278e242c4d2f131acc0/R/helper.R#L42

mrustl commented 5 years ago

Added tests back on appveyor in https://github.com/KWB-R/kwb.pkgbuild/commit/d22a5a1e3aa5a11d4725ad40a5d0873c83185422

mrustl commented 5 years ago

Now also fails on appveyor (as expected): https://ci.appveyor.com/project/KWB-R/kwb-pkgbuild/builds/23086034#L304