KWangechi / bank-codes-web-scrapper

A small project for getting all the bank codes and branches in Kenya
https://kenya-bank-code-search.pages.dev/
23 stars 10 forks source link

Improve search performance and simply logic. #11

Closed bwanamaina closed 2 months ago

bwanamaina commented 3 months ago

This PR aims to improve performance and separate search logic from the main application entry point(components) into custom hook(s). Currently search is triggered on every keystroke and the current results (UI) is replaced by skeleton and timeout is used to control the UI, this can be improved.

Proposal

Screenshot 2024-08-04 at 16 59 42

KWangechi commented 3 months ago

May also need to enable one to search "Bank Branch', 'Branch, Bank', 'Alias, Branch' ... e.g "KCB Ruiru' wields a 'No results found card'...

When searching just 'Ruiru' or 'KCB' individually, it works, however if used together, it doesn't work

Individually image

Separately image

bwanamaina commented 2 months ago

I will open a PR to handle this logic.