KWangechi / bank-codes-web-scrapper

A small project for getting all the bank codes and branches in Kenya
https://kenya-bank-code-search.pages.dev/
23 stars 10 forks source link

Resolves #11 improve performance around search logic #12

Closed bwanamaina closed 3 months ago

bwanamaina commented 3 months ago

This PR aims to improve performance and separate search logic from the main application entry point(components) into custom hook(s). Currently search is triggered on every keystroke and the current results (UI) is replaced by skeleton and timeout is used to control the UI, this can be improved.

Proposal

Screenshot 2024-08-04 at 16 59 42

bwanamaina commented 3 months ago

That's totally fine with me, you can pull it down and interact with it abit, In case you need me to make any changes I'll gladly do.

KWangechi commented 3 months ago

I am having an issue with the resolution of the path on local env... image

So not sure what's going on

bwanamaina commented 3 months ago

Could be an issue with webpack, after pulling latest changes, did you restart your dev server ? if not try kill the session and run npm start