KYLChiu / sporkfish

Chess engine in Python
MIT License
5 stars 0 forks source link

[SPORK-114] Move ordering refactor + composite move ordering #118

Closed KYLChiu closed 8 months ago

KYLChiu commented 8 months ago

See the linked issue #114 for motivation.

KYLChiu commented 8 months ago

I am keen to change the design, hence stopped reviewing in details. We briefly discussed before using a factory pattern but dropped the idea since we both didn't quite understand it. Want to pick up that discussion again.

You implemented SearcherFactory though! ;) maybe it's the essence of programming that we don't understand but somehow stuff works. Anyway, replied to all

ccjeremylo commented 8 months ago

I am keen to change the design, hence stopped reviewing in details. We briefly discussed before using a factory pattern but dropped the idea since we both didn't quite understand it. Want to pick up that discussion again.

You implemented SearcherFactory though! ;) maybe it's the essence of programming that we don't understand but somehow stuff works. Anyway, replied to all

Sorry I meant decorator - not factory!