KYLChiu
commented
6 months ago If ok with you both, @kwngggg will implement and @ccjeremylo will review please?
Closed KYLChiu closed 6 months ago
KYLChiu
commented
6 months ago If ok with you both, @kwngggg will implement and @ccjeremylo will review please?
You are Steve Jobs style programmer - seems you like closed systems
I personally like making everything configurable with default parameter - so noob users wouldn't even know you can change certain settings - but at least open to pro user to test/play around configs. Personal preference.
Regardless, this is something for a later PR.
_Originally posted by @ccjeremylo in https://github.com/KYLChiu/sporkfish/pull/118#discussion_r1494693282_
Requirements:
Make move ordering weights in composite move order configurable. This allows people to pick and choose which move ordering they need by selecting the ones the don't want and setting that weight to 0. See searcher/move_ordering/composite_heuristic.py for the weight dictionary.
Create a new config CompositeHeuristicConfig class which inherits from Configurable - see configurable.py.
Pass the settings into the weight dictionary.
Set the default settings to be the current settings in config.yml.