search

KYOSS / kyoss-topic-manager

A web application to allow members of KYOSS to vote on topics for meetings.
Apache License 2.0
3 stars 5 forks source link

Adopt a "Coding Standard" / "Style Guide" #6

Open zeroasterisk opened 10 years ago

zeroasterisk commented 10 years ago

I vote we adopt an existing style guide...

Nominations:

rsyring commented 10 years ago

4 spaces, please?

zeroasterisk commented 10 years ago

i think we can all "vote" but we have to end up with a convention - ideally a well documented, wholistic, set of conventions, used by some other public project in a similar space (JS, HTML, etc). Thus my recommendations.

InfoSec812 commented 10 years ago

I like indentation with tabs because then it is REALLY easy for each person to set the tab width to be displayed in their own environment, so I would go with the jquery guide in this instance...

rsyring commented 10 years ago

I've always avoided tabs due to PEP8 since I'm a python guy. It doesn't really matter to me as long. I would prefer not having two spaces as the standard...it makes it hard to distinguish indentation levels IMO.

InfoSec812 commented 10 years ago

I completely agree about 2 spaces.. It's not enough differentiation for my old-man eyes...

As for tabs versus spaces, I can live with either. My IDE will take care of it for me.

Deven

On Wed, Jul 9, 2014 at 9:42 AM, Randy Syring notifications@github.com wrote:

I've always avoided tabs due to PEP8 since I'm a python guy. It doesn't really matter to me as long. I would prefer not having two spaces as the standard...it makes it hard to distinguish indentation levels IMO.

— Reply to this email directly or view it on GitHub https://github.com/KYOSS/kyoss-topic-manager/issues/6#issuecomment-48470775 .

InfoSec812 commented 10 years ago

For the most part, after reading through, I am OK with PEP8 as a basis for us to work from.. The only complaint I have is that the line length of 79 characters is HORRENDOUS... Modern screens are capable of displaying MUCH more and putting stuff on a single line often improves readability (and where it doesn't, you can always have continuation lines).

Just my 2 cents.

Deven

On Wed, Jul 9, 2014 at 10:33 AM, Deven Phillips deven.phillips@gmail.com wrote:

I completely agree about 2 spaces.. It's not enough differentiation for my old-man eyes...

As for tabs versus spaces, I can live with either. My IDE will take care of it for me.

Deven

On Wed, Jul 9, 2014 at 9:42 AM, Randy Syring notifications@github.com wrote:

I've always avoided tabs due to PEP8 since I'm a python guy. It doesn't really matter to me as long. I would prefer not having two spaces as the standard...it makes it hard to distinguish indentation levels IMO.

— Reply to this email directly or view it on GitHub https://github.com/KYOSS/kyoss-topic-manager/issues/6#issuecomment-48470775 .

rsyring commented 10 years ago

Actually, I cheat on that one. I currently use 100. However, I have seen some recent discussion arguing for it:

http://wrongsideofmemphis.com/2013/03/25/80-chars-per-line-is-great/

I really don't have a dog in this fight, just like the conversation. :)

ghost commented 10 years ago

tabs for me...