search

KZDKM / Hyprspace

Workspace overview plugin for Hyprland
GNU General Public License v2.0
523 stars 16 forks source link

fix: wrong cast type #101

Closed horriblename closed 3 weeks ago

horriblename commented 3 weeks ago

fixes #56

I also updated hyprland input since it's causing nix build to fail

KZDKM commented 3 weeks ago

Sorry for the late response, was bogged down with schoolwork.

I don't see how the cast type is wrong. According to upstream documentation on touch events, all the arguments are passed as non-pointer types. The mouse movement and key / mouse button event handlers are all functional so I doubt that the touch events should be different. As with touch functions, I currently don't have any touchscreens to test it on to fix #56, but I'm pretty sure using touch with this patch applied would crash as args does not contain a pointer type. Since I could not test and debug touch without the hardware, I would probably remove touch support if the current implementation is causing crashes as reported in the issue. (nvm, my brain decided to shit itself

Source: 2024-10-29-171853_screenshot

horriblename commented 3 weeks ago

According to upstream documentation on touch events, all the arguments are passed as non-pointer types.

I changed from pointer to non-pointer though. and I did test it and it works

horriblename commented 3 weeks ago

I can help with touch screen stuff + I plan on adding mouse/swipe features to touch later, so don't worry about touch too much :)

KZDKM commented 3 weeks ago

wtf am I having a stroke, how did I read the diff the other way around, no way im clowning this hard lmao

My bad, the change for input handlers lgtm. I dont use nix so I dont know about whats going on in the flakes. But I will merge for now.

KZDKM commented 3 weeks ago

I can help with touch screen stuff + I plan on adding mouse/swipe features to touch later, so don't worry about touch too much :)

Of course, please do!