search

KZDKM / Hyprspace

Workspace overview plugin for Hyprland
GNU General Public License v2.0
523 stars 16 forks source link

Feature request: add icons in overlay #33

Open kooskaspers opened 7 months ago

kooskaspers commented 7 months ago

It would be nice to see the app's icon in the overlay. It makes it a bit more easier to recognize which app is where. Imagine red boxes are the app's icon:

image

KZDKM commented 7 months ago

Thank you, interesting suggestion, I suppose this is doable... The challenge is implementing an icon finder based on the icon theme. I would have to look into the code of ags and waybar.

kiecla commented 6 months ago

I think waybar just gets the icon from the windows class, and maps that to a string the user provides (which can be an icon for the program if using an icon font) I think hyprswitch has something closer to what this feature request is about https://github.com/H3rmt/hyprswitch https://github.com/H3rmt/hyprswitch/blob/main/imgs/image_2.png I can't read Rust very well, but I think this is the relevant code for retrieving the icons https://github.com/H3rmt/hyprswitch/blob/main/src/icons.rs

kooskaspers commented 5 months ago

I think waybar just gets the icon from the windows class, and maps that to a string the user provides (which can be an icon for the program if using an icon font) I think hyprswitch has something closer to what this feature request is about https://github.com/H3rmt/hyprswitch https://github.com/H3rmt/hyprswitch/blob/main/imgs/image_2.png I can't read Rust very well, but I think this is the relevant code for retrieving the icons https://github.com/H3rmt/hyprswitch/blob/main/src/icons.rs

Have been using hyprswitch for a while now. Seems to be a really great switcher. There is just one little downside: its slow compared to hyprspace, w.r.t. opening the overview / switcher. Thanks though for the suggestion.

kiecla commented 5 months ago

I prefer hyprspace personally even without the program icons, I only leave that reference to hyprswitch as a suggestion to KZDKM that might be more useful than looking at waybar, as I think that is closer to what you intended than the manual glyph-based way waybar icons work

5 Jun 2024 15:52:48 Koos Kaspers @.***>:

I think waybar just gets the icon from the windows class, and maps that to a string the user provides (which can be an icon for the program if using an icon font) I think hyprswitch has something closer to what this feature request is about https://github.com/H3rmt/hyprswitch https://github.com/H3rmt/hyprswitch/blob/main/imgs/image_2.png I can't read Rust very well, but I think this is the relevant code for retrieving the icons https://github.com/H3rmt/hyprswitch/blob/main/src/icons.rs

Have been using hyprswitch for a while now. Seems to be a really great switcher. There is just one little downside: its slow compared to hyprspace, w.r.t. opening the overview / switcher. Thanks though for the suggestion.

— Reply to this email directly, view it on GitHub[https://github.com/KZDKM/Hyprspace/issues/33#issuecomment-2150273197], or unsubscribe[https://github.com/notifications/unsubscribe-auth/A5WM5ZJLONUHQQPBYKZHUI3ZF4Q4BAVCNFSM6AAAAABGU363QOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJQGI3TGMJZG4]. You are receiving this because you commented. [Tracking image][https://github.com/notifications/beacon/A5WM5ZMYVTKU246QCIYZDXDZF4Q4BA5CNFSM6AAAAABGU363QOWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUAFKIK2.gif]