KZDKM / Hyprspace

Workspace overview plugin for Hyprland
GNU General Public License v2.0
285 stars 9 forks source link

Animations are a bit sluggish? #7

Closed dmadisetti closed 1 month ago

dmadisetti commented 1 month ago

Can we customize this, and if we can, can it be added to the docs?

Takes a good 10 seconds for things to settle for me, which is unlike my other animations

KZDKM commented 1 month ago

Noted, it is already in the docs, currently the plugin uses the windows animation keyword, which should use the same configuration as windows animations. I will try to declare a new animation keyword for the overview panel. Meanwhile, try to decrease the duration of windows animation in your hyprland config file.

dmadisetti commented 1 month ago

What are you using for reference? Here's mine:

animation=windows,1,5,overshot,slide

Reasonable at

animation=windows,1,1,overshot,slide

but not a fan of normal window animations now

KZDKM commented 1 month ago

My configuration is the same as the second line. The reason why it uses windows animation is I decided it as a placeholder when I was testing the animation implementation during early development. I will try to resolve it now.

dmadisetti commented 1 month ago

Got you. Changing workspace in overview mode is also much slower than normal change

KZDKM commented 1 month ago

See this commit: https://github.com/KZDKM/Hyprspace/commit/e3137ae3d89fafade5947cd1e9d2f721ac79d14c

The animation is still based on the windows animation but I added a config value for overriding the animation speed. I was not able to define a custom animation keyword (would probably look deeper into it later).

For switching workspace, the plugin just calls changeWorkspace just as the workspace dispatcher which you bind to hotkeys would do so I don't know how it would be different with overview open, could you send a video showing how it is slower?

dmadisetti commented 1 month ago

https://www.awesomescreenshot.com/video/26642462?key=52a26a5a5af746a35ce743d634a2630c

At the end I change/ create windows normally to show how snappy it is

dmadisetti commented 1 month ago

I will try out the new override at some point- need to get back to work for now

dmadisetti commented 1 month ago

But my config for reference: https://github.com/dmadisetti/.dots/blob/template/dot/config/hypr/hyprland.conf

KZDKM commented 1 month ago

Was able to reproduce. Probably caused the side effect of overriding the animated positions of windows when drawing workspace windows in overview mode which resets the animation timer of the real position. Wasn't apparent on my config so I did not notice at all. This should be a easy fix.

KZDKM commented 1 month ago

Fixed with https://github.com/KZDKM/Hyprspace/commit/1a3e22377c9ade3057ff80c9e79930b69adc915f.

Feel free to reopen if issue persists

dmadisetti commented 1 month ago

Works!