KaOSx / apps

KDE SC and applications
https://kaosx.us/packages/packages.php?sortby=name&sordir=asc&repo=apps
27 stars 20 forks source link

Add kompare and krename to krusader #209

Closed ShalokShalom closed 2 years ago

ShalokShalom commented 2 years ago

This adds diff and batch renaming

demmm commented 2 years ago

Depends listed are needed, not options, make sure to read what the app itself does: https://invent.kde.org/utilities/krusader/-/blob/master/krusader/krslots.cpp#L193 It does warn already for you to choose a diff option, same for krename.

ShalokShalom commented 2 years ago

Since the last 7 years, KaOS always included everything, since avoiding optdepends is part of the philosophy. I didn't knew that changed yet, while I guess it does so only for apps who show you, what else you can add.

demmm commented 2 years ago

Make sure you actually understand what you are asking. Kompare is part of the default install, but has never been a depend (hard) of dolphin, so anyone is free to remove kompare and use kdiff3 instead. You are asking now to force your preference on all users by making kompare a hard depend of krusader, leaving them no option to remove it and use another they might prefer instead. Seems again an issue of you choosing to do a minimal install, then complaining packages you want are not part of you're install (again, kompare is part of a normal install, so you not having it means you choose to remove it).

ShalokShalom commented 2 years ago

How does this count for krename and how can nobody choose an alternative, if Krusader gives you this option:

Screenshot_20220228_121732