search

Kaaveh / ComposeNews

A playground about best practices, using updated libraries and solutions in the Android world!
Apache License 2.0
318 stars 51 forks source link

Optimize/price change colors in market list #164

Closed mhmd-android closed 11 months ago

mhmd-android commented 11 months ago

This pull request introduces dynamic color selection for the price change indicator in our app. The goal is to improve the visual representation of price trends and enhance the user experience based on the system theme (light or dark mode).

Changes Made

Added four new colors to our theme:

  1. lightUptrendGreen for indicating an upward price trend in light mode.
  2. darkUptrendGreen for indicating an upward price trend in dark mode.
  3. lightDownTrendRed for indicating a downward price trend in light mode.
  4. darkDownTrendRed for indicating a downward price trend in dark mode.

I have tested the changes on some different dynamic light and dark themes to ensure that the selected colors work well with our app's design and provide a clear representation of price trends.

Screenshots:

Shot 0002 Shot 0001 Shot 0003 Shot 0004

Thank you for your review and feedback.

145

Kaaveh commented 11 months ago

Thanks @mhmd-android ! Great as always! 🙌🏻