search

Kaaveh / ComposeNews

A playground about best practices, using updated libraries and solutions in the Android world!
Apache License 2.0
282 stars 47 forks source link

Code generation for large screen preview #169

Closed Kaaveh closed 5 months ago

Kaaveh commented 9 months ago

According to our conversion in #166

mhmd-android commented 9 months ago

Hi, I'm here to take it 🤚

Kaaveh commented 6 months ago

Hey @mhmd-android, Do you have any updates on this task?

mhmd-android commented 6 months ago

Hey @Kaaveh Unfortunately, I didn't have enough time to work on this issue, but I will definitely take care of it as soon as possible

Kaaveh commented 5 months ago

Great, thanks @mhmd-android

mhmd-android commented 5 months ago

Hi dear @Kaaveh

After a thorough review of the proposed solution to use code generation to address the current issue in the ComposeNews project, I've concluded that this approach might not be the best solution for several reasons:

Limited Utility: While the idea of using a code generator for this specific problem might seem appealing, the truth is that its application would be limited to this particular case only, offering no reusability in other parts of the project or future projects.

Unnecessary Complexity: Introducing a code generation layer into the project could add unwanted complexity. This complexity might complicate code maintenance and understanding for other developers, especially those new to the project.

Focus on More Pragmatic Solutions: It would be more beneficial to explore solutions that enhance the code's maintainability and readability without introducing additional layers that might not add significant value.

Thank you for considering my perspective on this matter.

Kaaveh commented 5 months ago

@mhmd-android No problem, I think we can close this issue 👍