search

Kaaveh / ComposeNews

A playground about best practices, using updated libraries and solutions in the Android world!
Apache License 2.0
325 stars 53 forks source link

Update market detail loading with skeleton animation #189

Closed hadi-norouzi closed 1 year ago

hadi-norouzi commented 1 year ago

161

Kaaveh commented 1 year ago

Hey @hadi-norouzi , Thanks for your PR! Please run gradlew lintKotlin for showing you the formatting issues.

Kaaveh commented 1 year ago

Like this

Kaaveh commented 1 year ago

Thanks for fixing. Could you please add a screenshot to this PR description?

hadi-norouzi commented 1 year ago

Sure, i will.

On Mon, Nov 13, 2023 at 10:12 Kaaveh Mohamedi @.***> wrote:

Thanks for fixing. Could you please add a screenshot to this PR description?

— Reply to this email directly, view it on GitHub https://github.com/Kaaveh/ComposeNews/pull/189#issuecomment-1807554100, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKWE5Z45PSKVJXKEICOPM6LYEG6LXAVCNFSM6AAAAAA7IAHXY2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBXGU2TIMJQGA . You are receiving this because you were assigned.Message ID: @.***>

hadi-norouzi commented 1 year ago

I update the detail page with a scrollable column when it's in landscape mode.

Screenshot 2023-11-13 at 12 30 37 PM
Kaaveh commented 1 year ago

Amazing! Thanks for your contribution! We hope to see more PR from you! 🤩🙌🏻 close #161